OpenDevicePartnership / OpenDevicePartnership/embedded-services

thermal-service: Detect potential invalid/erroneous sensor readings

Open
#463 0 comments 0 reactions 1 assignee View on GitHub

@kurtjd is already working on this.

Since Aug 12, 2025.

Dominant language
Rust
Stars
23
Forks
53
Avg merge
2d 20h
Merged PRs (30d)
13

Description

Currently the thermal service will handle complete sensor failure adequately (as in, failures to communicate with the sensor at all) but should implement a way to detect if readings might be invalid even if we can communicate with the sensor. For example, if the sensor is repeatedly reporting temperatures outside of an expected range we should treat these as suspect and mark the sensor invalid and take appropriate actions (such as possibly telling fans that depend on the sensor to run at max speed).

Would also want to detect momentary spikes and discard them. For example if sensor has been reading steadily within a certain range and then suddenly we receive a sample that is considerably higher which may trigger a PROCHOT, wait to see if we get that sample several more times before actually triggering a prochot.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.