OpenDevicePartnership / OpenDevicePartnership/embedded-services

Fixup HID I2C device command response messages

Open
#259 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Rust
Stars
23
Forks
53
Avg merge
2d 20h
Merged PRs (30d)
13

Description

https://github.com/RobertZ2011/odp-embedded-services/blob/5cd46e09f843f5718f12fc7c8803a6c21e240665/hid-service/src/i2c/device.rs#L143

Current this only returns a feature response instead of a specific response for each command. In general this should work because a feature request contains arbitrary data so it currently doesn't affect anything, but this is something that should be addressed.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in hid-service/src/i2c/device.rs at line 143 and inspect how command requests are matched to response messages. Update the response selection so each command receives its specific response rather than a generic feature response, then verify that the command response behavior remains correct.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
embedded-iot
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
58/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.