OpenCyphal / OpenCyphal/pycyphal
Redundant check for frame_index==0 in the high-overhead transfer reassembler
Open
Nobody has claimed this yet.
class-defect
domain-core
severity-minor
- Dominant language
- Python
- Stars
- 142
- Forks
- 110
- PR merge metrics
- No merged PRs in 30d
Description
Transfers may not begin with the first frame in the presence of frame reordering:
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read pycyphal/transport/commons/high_overhead_transport/_transfer_reassembler.py at the linked lines and trace how frame reordering is handled before the frame_index check. Confirm why the check is redundant and identify the smallest safe cleanup; done means the reassembler no longer performs the unnecessary check while preserving transfers that begin after frame 0.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- networking
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100