OpenCut-app / OpenCut-app/OpenCut
[BUG] Unsafe std::env::remove_var in WSL2 workaround
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 89.8k
- Forks
- 8.9k
- PR merge metrics
- No merged PRs in 30d
Description
Bug Report
Platform
Linux (WSL2 specifically), potentially macOS
Current Behavior
In apps/desktop/src/main.rs:28-30, the code uses unsafe { std::env::remove_var("WAYLAND_DISPLAY") } to work around a GPUI 0.2.2 WSLg issue:
unsafe {
std::env::remove_var("WAYLAND_DISPLAY");
}
Problems
- Thread-safety violation:
std::env::remove_varis NOT thread-safe. If any other thread reads the environment concurrently (common in async runtimes), this causes undefined behavior. - Fragile assumption: The comment claims "this is the first statement in main" but any future code added above breaks this guarantee.
- Process-wide side effect: Modifies environment for the entire process, affecting child processes and other threads.
Expected Behavior
Use thread-safe alternatives:
std::env::set_var("WAYLAND_DISPLAY", "")to unset (still not fully thread-safe but safer)- Or better: configure the GPUI/Winit window builder to use X11 explicitly via
WAYLAND_DISPLAY="" cargo runat process spawn - Or set the env var before spawning the process via
Command::env_remove("WAYLAND_DISPLAY")
Steps To Reproduce
- Run on WSL2 with both X11 and Wayland configured
- App may crash or behave unpredictably under concurrent env access
Recurrence Probability
Sometimes - race condition dependent
Additional Context
This is a soundness issue in Rust. The unsafe block doesn't actually make the operation safe - it just tells the compiler you've verified safety, which isn't true here.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in apps/desktop/src/main.rs:28-30 and inspect how the application starts and how the GPUI 0.2.2 WSLg workaround is applied. Determine a thread-safe way to handle WAYLAND_DISPLAY without an unsafe process-wide mutation, then verify the behavior on WSL2 and macOS where applicable.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- desktop, operating-systems
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100