OpenConext / OpenConext/Stepup-Middleware

PHPUnit tests end up in releases

Open
#559 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
PHP
Stars
3
Forks
2
Avg merge
2d 9h
Merged PRs (30d)
2

Description

When building a release, the src/**/Tests are not excluded from the composer archive.

That should not be a problem as there are no secrets stored, or harmful exploits in the unit tests. Still, a prod release could exclude that code. You would not be able to run those tests in production anyway as phpunit is installed as a dev dependency.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the Composer archive configuration and checking how the src/**/Tests paths are included in a release archive. Build or inspect a representative archive and confirm that PHPUnit test directories are excluded while production code remains available.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
build-system, release
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.