OpenConext / OpenConext/Stepup-Gateway

Upgrade to PHP 8.5 and apply Rector cleanup

Open
#634 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
PHP
Stars
6
Forks
3
Avg merge
1d 10h
Merged PRs (30d)
10

Description

Goal

Upgrade PHP runtime to 8.5, update Composer dependencies, and apply Rector cleanup.

What needs to be done

  • Bump composer.json PHP constraint to ^8.5, run composer update
  • Update Dockerfile(s)/docker-compose and CI to PHP 8.5
  • Add rector/rector: ^2.4, add rector.php:
    return RectorConfig::configure()
        ->withPaths([__DIR__.'/bin', __DIR__.'/config', __DIR__.'/src', __DIR__.'/tests'])
        ->withPhpSets()
        ->withComposerBased(doctrine: true, symfony: true, phpunit: true)
        ->withAttributesSets(doctrine: true, symfony: true, phpunit: true)
        ->withSkip([
            \Rector\Php84\Rector\MethodCall\NewMethodCallWithoutParenthesesRector::class,
            \Rector\Php84\Rector\Class_\DeprecatedAnnotationToDeprecatedAttributeRector::class,
        ]);
    
  • Apply rector, fix what it can't (implicit nullable params, __sleep/__wakeup, removed functions like xml_parser_free())
  • Full test suite + static analysis green on PHP 8.5

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with composer.json, the Dockerfile(s), docker-compose configuration, and CI configuration to map the PHP 8.5 upgrade. Add the requested rector.php configuration, then apply Rector across bin, config, src, and tests and review the listed compatibility fixes. Done means Composer dependencies are updated and the full test suite plus static analysis are green on PHP 8.5.

Written by the indexing model from the issue text.

Assessment

Tech stack
docker, php
Domain
backend, ci-cd, devops, tooling
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.