OpenConext / OpenConext/Stepup-Build
Update of stepup-build2.sh for support of newer Symfony versions
Nobody has claimed this yet.
- Dominant language
- Shell
- Stars
- 0
- Forks
- 1
- PR merge metrics
- No merged PRs in 30d
Description
Looking at: https://github.com/OpenConext/Stepup-Build/blob/main/stepup-build2.sh#L228-L231
We observe a APP_ENV=prod declaration in the build environment. But only when SYMFONY_VERSION = 4.
Now that the recent upgrades start installing Symfony 7, we might need to update the script to also write that ENV var to the build environment for higher Symfony versions.
Suggestion:
if [ ${SYMFONY_VERSION} -ge 4 ]; then
# Set APP_ENV=prod for symfony Flex
do_command "export APP_ENV=${SYMFONY_ENV}"
fi
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read stepup-build2.sh around lines 228-231 and inspect how SYMFONY_VERSION controls the APP_ENV export. Confirm the condition covers the newer Symfony versions described in the issue, then verify the build environment receives APP_ENV=prod for Symfony 7.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- shell, symfony
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 72/100