OpenConext / OpenConext/OpenConext-oidcng
Make the "nonce" auth request parameter optional in the hybrid "code token" flow
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 4
- Forks
- 6
- Avg merge
- 5d 32m
- Merged PRs (30d)
- 3
Description
This issue is imported from pivotal - Originaly created at Dec 7, 2020 by Bart Geesink
Only when issuing an id_token, the nonce must be present. So in the hybrid flow "code token" nonce can be omitted.
Caused by the nimbus library: https://bitbucket.org/connect2id/oauth-2.0-sdk-with-openid-connect-extensions/src/7da4c0b7f9ad10ea08e4ed970d527f7ec37d67f0/src/main/java/com/nimbusds/openid/connect/sdk/AuthenticationRequest.java#lines-1680
Added question in the. code: https://github.com/OpenConext/OpenConext-oidcng/commit/1efc29f61ed9caf7ad85590f9f18b939c56b1b1b
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the linked Nimbus AuthenticationRequest.java code and the referenced OpenConext commit to understand why nonce is currently required. Verify the hybrid "code token" flow accepts requests without nonce when no id_token is issued, while requests issuing an id_token still require it.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- authentication
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100