OpenConext / OpenConext/OpenConext-engineblock
Add tests for presence of `RelayState` and `return` parameters sent to the SP
Open
Nobody has claimed this yet.
tests
- Dominant language
- PHP
- Stars
- 17
- Forks
- 25
- Avg merge
- 4d 1h
- Merged PRs (30d)
- 1
Description
Add functional tests for the presence of the RelayState and return parameters in the SAML POST to the SP.
The tests are currently not present so if the RelayState parameter get lost somewhere in the login flow, this is not detected.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No file or test path is named. Start by locating the existing functional test for the SAML login flow and inspect the POST sent to the SP; add assertions for the RelayState and return parameters, then run the test to confirm both are present.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- authentication, testing
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100