OpenConext / OpenConext/OpenConext-engineblock
Remove obsolete Consent hashing code
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 17
- Forks
- 25
- Avg merge
- 4d 1h
- Merged PRs (30d)
- 1
Description
In pr #1137 we have made a stable solution for hashing the consent. This was needed as users sometimes would get asked to give consent even tho nothing changed.
Too make it backwards compatible we made a new column where the new hashes are safed for that reason.
After sometime the code should be dead and not used anymore. This is why we should remove it from the codebase and only support he new stable hashes
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing PR #1137 and trace the older consent-hashing path and its backwards-compatibility column through the codebase. Identify the tests covering consent hashes, then remove the obsolete implementation while retaining support for the stable hashes introduced there. Done means the legacy code and migration path are gone and the relevant tests still pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- authentication
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100