OpenConext / OpenConext/OpenConext-engineblock

[Consent] Better solution for consent if attribute mapping is active

Open
#1,738 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Imported not-ready
Dominant language
PHP
Stars
17
Forks
25
Avg merge
4d 1h
Merged PRs (30d)
1

Description

This issue is imported from pivotal - Originaly created at Mar 31, 2021 by Arnout Terpstra

If attribute mapping is active, ALL attributes are displayed in the consent screen, even when only a subset is actually used. Currently IdPs only have the option to entirely disable the consent screen.

"Het zou ook fijn zijn dat wanneer je een eigen consent tekst maakt, dat dan het attributen overzicht ook verdwijnt. Feature request?"

https://jira.surfnet.nl/browse/CXT-52535

We probably need a 4th setting in Manage: custom_msg_only (or something). When set:

  • The IdP MUST set a custom message for a specific SP
  • The table with attributes is NOT shown
  • Instead and within that same frame (belonging to 'provided by '): the custom msg is shown
  • Rest of the screen remains the same

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the consent screen and the Manage settings for attribute mapping and consent-screen disabling. Confirm how a custom message is configured for a specific SP, then define the behavior for a custom-message-only setting: require the message, hide the attribute table, and keep the rest of the screen unchanged.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
authentication
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.