OpenConext / OpenConext/OpenConext-engineblock
Cypress infra and additional dependencies are isolated in docker image
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 17
- Forks
- 25
- Avg merge
- 4d 1h
- Merged PRs (30d)
- 1
Description
This issue is imported from pivotal - Originaly created at Aug 30, 2023 by Michiel Kodde
The cypresss tests are a valuable asset. They verify the a11y principles in our themes.
They however are rather fragile. And often stop working, or start to conflict with other build related packages found in our package.json
Given the e2e nature of the Cypress suite. It is a logical solution to isolate it into a container of it's own. Leaving the PHP container to be focussed on the EB application and not worry itself with Cypress and it's peers.
Proposal:
The existing cypress-included image should be extended into an image of our own (in basecontainers?) That image should have:
Cypress
Axe (for ally testing)
The test browser (s)
The other infra required to run them
It might be a good idea to run the cypress tests in a stage of their own. So not runnign them in the test-integration GHA, but have another e2e workflow tailormade for the cypress tests. But it might be.
Feel free to discuss
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review package.json, the existing cypress-included image, basecontainers, and the test-integration GHA workflow. Determine which Cypress, Axe, browser, and infrastructure dependencies need isolation. Done means Cypress accessibility tests run in their own container or workflow without conflicting with the PHP container's build dependencies.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cypress, docker, github-actions, php
- Domain
- ci-cd, devops, testing
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100