OpenConext / OpenConext/OpenConext-engineblock
Logo field still used by consent screen
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 17
- Forks
- 25
- Avg merge
- 4d 1h
- Merged PRs (30d)
- 1
Description
This issue is imported from pivotal - Originaly created at Jan 8, 2024 by Thijs Kinkhorst
In EB 6.11 the logo field was moved to the mdui field in sso_provider_roles_eb5. However the consent screen still uses the value that is in the logo field. Therefore this field cannot yet be removed.
Reproduce: in database, set logo field of an IdP to different image than is in the mdui field for that entity. The WAYF (and PDP message) show the logo from mdui, consent screen shows the different image.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the consent-screen rendering path and compare its logo source with the mdui value already used by the WAYF and PDP message. Reproduce the issue by setting different logo and mdui images for an IdP; done means the consent screen shows the same image as the other views and the legacy logo value is no longer required for this behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- authentication
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100