Remove long deprecated input variables from Attribute Manipulation

Open
#1,260 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Stale
Tech stack
php
Domain
authentication

Research direction

Start by locating the Attribute Manipulation implementation and search for uses of $response, $idpMetadata, and $spMetadata, including whether $response is modified by reference. Confirm which legacy variables are unused before removing them; done means unused variables are no longer generated without changing the remaining Attribute Manipulation behavior.

Written by the indexing model from the issue text.

Description

needs-discussion

The following variables are available in an Attribute Manipulation: &$response, $idpMetadata, $spMetadata but generated via complicated legacy code.

$response is passed by reference so can be modified, the others are read only. $response can most likely be replaced by $responseObj but since that cannot be modified currently (not passed by reference), it's not yet a full replacement.

Also we can only drop the legacy variables when they are actually unused.

Dominant language
PHP
Stars
17
Forks
25
Avg merge
4d 1h
Merged PRs (30d)
1

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from OpenConext/OpenConext-engineblock

All issues in OpenConext/OpenConext-engineblock

Similar issues

More PHP issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.