OpenConext / OpenConext/OpenConext-engineblock

For IDP AuthnRequest force use of EB's default key

Open
#1,241 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
PHP
Stars
17
Forks
25
Avg merge
4d 1h
Merged PRs (30d)
1

Description

In addition to https://github.com/OpenConext/OpenConext-engineblock/pull/1231 we see the same incorrect behaviour towards IDPs when an SP uses the key-slug SSO-endpoints.

The default key should always be used for signed AuthnRequests towards IDPs

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Use the behavior described in issue #1241 and compare it with the related changes in pull request #1231. Trace how signed AuthnRequests are selected when an SP uses the key-slug SSO-endpoints, then verify that requests sent toward IDPs always use EB's default key.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
authentication
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.