OpenConext / OpenConext/OpenConext-dashboard

Wrong use of SAB API

Open
#653 0 comments 0 reactions 1 assignee View on GitHub

@teunfransen is already working on this.

Since Dec 20, 2024.

Dominant language
JavaScript
Stars
8
Forks
2
No merged PRs in 30d

Description

In the SABClient the method getSabEmailsForOrganization(String entityId, String role) is delegated to getPersonsInRoleForOrganization(entityId, role). However the last method expects an organisation GUID. As a result this will always return an empty List. Solution would be to use the Manage API to get the coin:institution_guid with the entityId as search parameter.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.