OpenChemistry / OpenChemistry/stempy
get_scan_path bug
Open
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 26
- Forks
- 12
- Avg merge
- 1d 2h
- Merged PRs (30d)
- 5
Description
There is a problem with get_scan_path when standard and centered data are in the same directory and only a scan_id is provided
This line needs to be updated to match proceeding lines:
file_pattern = f"*_id{scan_id}*_electrons{file_suffix.value}.{filetype}"
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open python/stempy/contrib/init.py and inspect get_scan_path around line 66, comparing its file pattern with the proceeding lines. Update the pattern so providing only scan_id distinguishes standard and centered data in the same directory, then verify that both cases select the intended files.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100