OpenChemistry / OpenChemistry/stempy
add option to counting
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 26
- Forks
- 12
- Avg merge
- 1d 2h
- Merged PRs (30d)
- 5
Description
Can we add an option to electron_count which will bypass the threshold calculation?
It would be great to have keywords for background_threshold and xray_threshold. These are meant to be the values which are currently determined by the sigma inputs with Gaussian fitting.
If the new parameters are input then the Gaussian fitting is skipped and the values are used directly. It would essentially skip the line res = _image.calculate_thresholds(*args) and use the thresholds directly from the user.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the electron_count entry point and trace the call to _image.calculate_thresholds(*args). Check how existing sigma inputs and threshold values are handled. Done means background_threshold and xray_threshold can be supplied as keywords, bypass Gaussian fitting, and are used directly.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp, python
- Domain
- computer-vision
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100