OpenChemistry / OpenChemistry/stempy
radial_sum_sparse center is different
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 26
- Forks
- 12
- Avg merge
- 1d 2h
- Merged PRs (30d)
- 5
Description
I want to document that radial_sum_sparse has a different center than other stempy functions like create_stem_images.
I will need to fix this so that everything matches, and we should document how to determine the center. I have a small-ish dataset where we can test this in the future:
# Input center as (col, row)
center = (185, 398) # or use stempy.image.com_dense()
fg,ax = plt.subplots(1,1)
ax.imshow(dp)
ax.scatter(center[0], center[1],c='r')
ax.legend(['center of pattern'])
# STEM images
images = stim.create_stem_images(electron_events, (0, 180), (50, 280), center=center) # here center is (row, col)
# Radial sum
radial_sum = stim.radial_sum_sparse(ee3, crop_dimensions, (576,576), center[::-1]) # center is (col, row)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by comparing the center conventions used by radial_sum_sparse and create_stem_images, using the provided small dataset and examples as the reproduction case. Determine the shared center convention, make both functions consistent, and document how to determine and pass the center.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp, python
- Domain
- computer-vision, data
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100