OpenBankProject / OpenBankProject/OBP-API
Inaccurate response for Get Current FxRate
Nobody has claimed this yet.
- Dominant language
- Scala
- Stars
- 1.7k
- Forks
- 482
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 15
Description
Inaccurate message issue
When a 'Get Current FxRate' operation was attempted with a known valid bank, an invalid message was returned stating that the bank was not found. We believe that the bank is there but the fx rate data is not. The message is therefore inaccurate.
Example:
GET https://apisandbox.openbankproject.com/obp/v3.0.0/banks/rbs/fx/EUR/GBP
Incorrect response
400 Bad Request
{
"error": "OBP-30001: Bank not found. Please specify a valid value for BANK_ID."
}
The bank does exist, if feature is not implemented should return a more informative response.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the documented GET /obp/v3.0.0/banks/rbs/fx/EUR/GBP request, then trace the handler that returns OBP-30001 for the current FxRate operation. Check how an existing bank is distinguished from missing FX-rate data. Done means the response accurately identifies unavailable or unimplemented FX-rate data instead of claiming that the bank is missing.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- scala
- Domain
- api, backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100