OpenBankProject / OpenBankProject/OBP-API

ATM/Branches update

Open
#666 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Scala
Stars
1.7k
Forks
482
Avg merge
1d 12h
Merged PRs (30d)
15

Description

  1. Change Branch Lobby / Drive up hours to reflect opening/closing time for each day of the week (so far it's represented like this:

"lobby":{
"hours":"Mon: 9:00am - 4:30pm, Tue: 9:00am - 4:30pm, Wed: 9:00am - 4:30pm, Thu: 9:00am - 4:30pm, Fri: 9:00am - 5:00pm"
},
"drive_up":{
"hours":"Mon: 9:00am - 4:30pm, Tue: 9:00am - 4:30pm, Wed: 9:00am - 4:30pm, Thu: 9:00am - 4:30pm, Fri: 9:00am - 5:00pm"
},

  1. Add Opening/Closing hours for each day of the week for the ATM resource
  2. Add extra field to ATM resource: Disability Access (Boolean)
  3. Add extra field to ATM resource: Deposit Capability (Boolean)
  4. Add extra field to ATM resource: Type (String)
  5. Add extra field to ATM resource: Info (String)
  6. Add extra field to Branch resource: Type (String)
  7. Add extra field to Branch resource: Info (String)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the ATM and Branch resource definitions and reviewing how their existing hours fields are represented. Done means daily lobby, drive-up, and ATM hours are supported, and the requested ATM and Branch fields are present with the specified types.

Written by the indexing model from the issue text.

Assessment

Tech stack
scala
Domain
api, backend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.