OpenBankProject / OpenBankProject/OBP-API

v210 Create Transaction SEPA mapped should not create account

Open
#607 1 comment 0 reactions 1 assignee View on GitHub

@hongwei1 is already working on this.

Since Jun 19, 2017.

Dominant language
Scala
Stars
1.7k
Forks
482
Avg merge
1d 12h
Merged PRs (30d)
15

Description

APIMethods210.scala

We should not implicitly create account here.
(we should throw error if the Counterparty does not exist.)

              //if the connector is mapped, we get the data from local mapper
              toAccount <- if(isMapped)
                // TODO should not create bank account here!!
                LocalMappedConnector.createOrUpdateMappedBankAccount(toBankId, toAccountId, fromAccount.currency)

Also see SEPA

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.