OpenBankProject / OpenBankProject/OBP-API

createCustomer: date_of_birth, dependants & face_image.date mandatory

Open
#565 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Scala
Stars
1.7k
Forks
482
Avg merge
1d 12h
Merged PRs (30d)
15

Description

If the fields date_of_birth, dependants or face_image.date have not been filled, the API throws an error:

APIError OBP-10001: Incorrect json format.

I reckon not providing them should neither result in the error message 'incorrect json format` nor should they be mandatory.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the createCustomer API entry point and trace the JSON validation for date_of_birth, dependants, and face_image.date. Verify that requests omitting these fields are accepted and that the incorrect-json-format error is not returned for their absence; add or update a focused test if the validation area identifies one.

Written by the indexing model from the issue text.

Assessment

Tech stack
scala
Domain
api, backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.