OpenBankProject / OpenBankProject/OBP-API
Add canSeeBankAccountRoutingScheme and canSeeBankAccountRoutingAddress to View
Nobody has claimed this yet.
- Dominant language
- Scala
- Stars
- 1.7k
- Forks
- 482
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 15
Description
Add canSeeBankAccountRoutingScheme and canSeeBankAccountRoutingAddress to View
and use to moderate here:
def moderate(bankAccount: BankAccount) : Option[ModeratedBankAccount] = {
.....snip.....
val accountRoutingScheme = Some(bankAccount.accountRoutingScheme) // TODO moderate this with canSeeBankAccountRoutingScheme
val accountRoutingAddress = Some(bankAccount.accountRoutingAddress) // TODO moderate this with canSeeBankAccountRoutingAddress
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the View definition and the moderate method shown in the issue. Read how existing canSee permissions are represented and how ModeratedBankAccount is built; done means both routing fields are exposed through View and are moderated according to the two new permissions.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- scala
- Domain
- api, backend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100