OpenBankProject / OpenBankProject/OBP-API
Add pagination by date for get meetings
Nobody has claimed this yet.
- Dominant language
- Scala
- Stars
- 1.7k
- Forks
- 482
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 15
Description
Please support the obp_from_date and obp_to_date pagination headers with GET /banks/BANK_ID/meetings call (in the same way as when getting transactions).
If this just involves copying boiler plate from get transactions, then obp_limit and obp_offset would also be useful, though its the date headers for which there is a very strong need.
API Explorer describes the format for the date parameters as including sub-seconds "yyyy-MM-dd'T'HH:mm:ss.SSS'Z'", while everywhere else seems to use "yyyy-MM-dd'T'HH:mm:ss'Z'". Is this deliberate in getTransactions, or just an oversight? Really don't see a need for sub-seconds.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by comparing the GET /banks/BANK_ID/meetings implementation with the existing get transactions pagination described in the linked REST API documentation. Verify how obp_from_date and obp_to_date are parsed and whether the documented sub-second format matches existing behavior. Done means meeting results support the requested date headers, with obp_limit and obp_offset addressed if the same pagination path makes them applicable.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- scala
- Domain
- api, backend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100