OpenBankProject / OpenBankProject/OBP-API
Do not allow SHA1?
Open
Nobody has claimed this yet.
question
- Dominant language
- Scala
- Stars
- 1.7k
- Forks
- 482
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 15
Description
SHA1 has been shattered: http://shattered.it/
(https://shattered.it/static/shattered.pdf)
src/main/scala/code/api/oauth1.0.scala allows the client to connect via SHA1. Maybe the API should be more restrictive and only allow SHA256?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading src/main/scala/code/api/oauth1.0.scala and locate how SHA1 is accepted for client connections. Confirm the intended restriction with the project’s OAuth 1.0 behavior, then verify that SHA1 is rejected while SHA256 remains allowed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- scala
- Domain
- authentication, security
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100