OpenBankProject / OpenBankProject/OBP-API

Extend test for Create Counterparty

Open
#363 0 comments 0 reactions 1 assignee View on GitHub

@hongwei1 is already working on this.

Since Feb 3, 2017.

Dominant language
Scala
Stars
1.7k
Forks
482
Avg merge
1d 12h
Merged PRs (30d)
15

Description

We currently have

protected def createCounterparty(bankId: String, accountId: String, iban: String, isBeneficiary: Boolean, counterpartyId: String): CounterpartyTrait

but should have bank scheme and address, account scheme and address (replaces iban) in parameters (basically all the fields in Counterparty)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.