OpenBankProject / OpenBankProject/OBP-API

Consider better parsing of Kafka response in case of unexpected errors

Open
#341 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Scala
Stars
1.7k
Forks
482
Avg merge
1d 12h
Merged PRs (30d)
15

Description

For instance if send request to get banks and there is no defined getBanks at response side of Kafka we get generic error:
"Bad response code (500) from OBP API server: ..."
instead of handling {"error":"unknown request"} which actually Kafka provide it.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Trace the Kafka response handling for the get-banks request; no source file or test is named in the issue. Reproduce the case where Kafka returns {"error":"unknown request"} instead of a defined getBanks response, then verify that this structured error is handled rather than surfaced as a generic HTML 500 response.

Written by the indexing model from the issue text.

Assessment

Tech stack
kafka, scala
Domain
api, backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.