OpenBankProject / OpenBankProject/OBP-API
Empty holder after sandbox data import
Nobody has claimed this yet.
- Dominant language
- Scala
- Stars
- 1.7k
- Forks
- 482
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 15
Description
I couldn't pin it down in the API's source yet, but in SoFi i observed empty counterparties in the transactions list on my local machine:
- Import data from https://raw.githubusercontent.com/OpenBankProject/OBP-API/develop/src/main/scala/code/api/sandbox/example_data/example_import.json into local API .
- Make a payment from one of those accounts to another using https://raw.githubusercontent.com/OpenBankProject/Hello-OBP-OAuth1.0a-Python/master/hello_payments_v1.4.py
- When looking at the transactions list in SoFi (http://localhost:8081/banks/BANK/accounts/ACCOUNT/owner), being authorised as the receiving account's owner, the name of the counterparty is empty.
- Using the API explorer (on http://localhost:8082) , calling /banks/BANK/accounts/ACCOUNT/owner/other_accounts (API Root: http://127.0.0.1:8080/obp/v2.0.0), the returned JSON returns an empty 'name' in the 'holder' field for that counterparty (which is used by SoFi for display)
Maybe at some stage somebody will have the time to look into it (maybe even me), but for now i thought to have it here as a reminder.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue by importing example_import.json, making a payment with hello_payments_v1.4.py, and inspecting /banks/BANK/accounts/ACCOUNT/owner/other_accounts in the API explorer. Trace where the counterparty holder is produced; done means the JSON holder.name is populated and the receiving owner's transaction list displays the counterparty name.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- scala
- Domain
- api
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100