OpenBankProject / OpenBankProject/OBP-API

Validate fields like amount and currency in SANDBOX_TAN

Open
#217 1 comment 0 reactions 1 assignee View on GitHub

@hongwei1 is already working on this.

Since Dec 1, 2016.

Dominant language
Scala
Stars
1.7k
Forks
482
Avg merge
1d 12h
Merged PRs (30d)
15

Description

Need to guard amount so it is sure to be convertable to Decimal

See

def getTransactionRequestDetailsSandBoxTanFromJson

// TODO Add Error handling and return Error message to the caller
// e.g. if amount is not a number, return "OBP-XXXX Not a Number"
// e.g. if currency is not a 3 letter ISO code, return "OBP-XXXX Not an ISO currency"

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.