OpenBagTwo / OpenBagTwo/LighterEnd
Clean up fabric dependencies in 1.21.11+ builds
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 8
- Forks
- 6
- PR merge metrics
- No merged PRs in 30d
Description
Is your feature request related to a problem? Please describe.
As I was updating the new builds to Modrinth, I noticed that:
- 1.21.11 is still specified as being compatible with any version greater than 1.21.10: https://github.com/OpenBagTwo/LighterEnd/blob/7c41ac9409ab985924957470974fbfd26b5eb42a/src/main/resources/fabric.mod.json#L14
- 26.1 is still specified as being compatible with any version greater than "26.0": https://github.com/OpenBagTwo/LighterEnd/blob/fc03ec24de0cec9afae9062f553dc854c43b2c77/src/main/resources/fabric.mod.json#L14
- Most egregiously, the 26.2 build lists the exact same dependency! https://github.com/OpenBagTwo/LighterEnd/blob/2be62515ae175704da3c8cc324ba9609df2aa1cb/src/main/resources/fabric.mod.json#L14
Describe the solution you'd like
Fix the above lines on each of their respective branches to represent the versions they actually are compatible with
Describe alternatives you've considered
Do nothing 🙃
Additional context
- I'm not going to bother to cut new releases just for these changes
- At some point there's going to be some rebasing to keep the commit history linear, but that's not anything that needs to be worried about until the next release
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect src/main/resources/fabric.mod.json at the referenced commits and on each relevant branch, starting at the dependency declaration on line 14. Compare the declared versions with the versions each 1.21.11, 26.1, and 26.2 build actually supports, then verify that each branch's metadata contains the appropriate dependency range.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- build-system, game-dev
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 68/100