OpenBMB / OpenBMB/PilotDeck

Meeting minutes extraction treats current meeting dates as next meetings

Open Beginner friendly
#414 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
4k
Forks
453
Avg merge
12h 30m
Merged PRs (30d)
46

Description

Summary

extract_next_meeting falls back to matching any ISO-like date after explicit next meeting markers fail. This causes current meeting dates, such as Meeting date: 2024-01-01, to be reported as the next meeting.

Tested on OpenBMB/PilotDeck main at 0907c5c9ae66cc155f36775fc8472b3ea621880d.

Code path

  • skills/meeting-recorder-assistant/scripts/meeting_minutes.py:171 defines extract_next_meeting.
  • skills/meeting-recorder-assistant/scripts/meeting_minutes.py:174-176 first matches explicit next-meeting labels, then falls back to any ISO-like date.
  • skills/meeting-recorder-assistant/scripts/meeting_minutes.py:45 stores the result as next_meeting.
  • skills/meeting-recorder-assistant/scripts/meeting_minutes.py:218 renders a Next Meeting section when this value is present.
  • skills/meeting-recorder-assistant/SKILL.md:39-42 shows the public skill flow calling generate_minutes.

Steps to reproduce

Call:

extract_next_meeting("Meeting date: 2024-01-01\nAgenda: weekly review.\n")

Observed dynamic repro:

actual: "2024-01-01"
expected: None

Positive control:

extract_next_meeting("Next meeting: 2024-01-01\n")

returns "2024-01-01" as expected.

Expected behavior

A current meeting date should not be rendered as next_meeting unless the transcript explicitly labels it as a next/follow-up meeting.

Actual behavior

Any ISO-like date can populate next_meeting, which then appears under the generated ## Next Meeting section.

Existing coverage

I searched current issues and PRs for extract_next_meeting, next meeting, Meeting date, and meeting_minutes, and did not find an existing issue or PR covering this root cause. Open PRs do not modify skills/meeting-recorder-assistant/scripts/meeting_minutes.py.

Suggested fix

Remove the generic any-date fallback, or restrict extraction to explicit next/follow-up labels such as next meeting, follow-up meeting, and 下次会议. If fuzzy extraction is desired, return confidence or field provenance rather than directly rendering the value as Next Meeting.

Suggested tests

  • Meeting date: YYYY-MM-DD should return None.
  • 会议日期:YYYY-MM-DD should return None.
  • Next meeting: YYYY-MM-DD should return the date.
  • 下次会议:YYYY-MM-DD should return the date.

Submitted with Codex.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at extract_next_meeting in skills/meeting-recorder-assistant/scripts/meeting_minutes.py:171 and reproduce the current-date and explicit-next-meeting examples. Add regression coverage for the four listed date-label cases; done means current meeting dates return None while next or follow-up meeting dates still populate the rendered Next Meeting section.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Clearly specified
Newbie friendliness
84/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.