OpenBMB / OpenBMB/MiniCPM-o-Demo
【bug】【fix】启动脚本卡住
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 386
- Forks
- 81
- Avg merge
- 1h 59m
- Merged PRs (30d)
- 3
Description
在 start_all.sh 脚本中，通过 curl -s "http://localhost:$WORKER_PORT/health" 检测 worker 是否就绪。如果 curl 命令工具没有安装，就会循环等待，虽然脚本设置了 set -e ，但是当 curl 出现在条件判断位置时，即使命令失败，也不会触发退出。
建议将
if curl -s ... | python3 ...; then
...
fi`
这种写法改成：
while [ $RETRY -lt $MAX_RETRIES ]; do
curl -s ...
...
sleep 2
done
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading start_all.sh, especially the worker health check using curl and python3. Run the script with curl unavailable to reproduce the endless wait, then verify that the readiness check respects the retry limit and exits instead of looping indefinitely.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python, shell
- Domain
- devops
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 52/100