OpenAstronomy / OpenAstronomy/minimum_dependencies
Plugin breaks on having the package name in the package deps
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 9
- Forks
- 4
- PR merge metrics
- No merged PRs in 30d
Description
Since we moved to pyproject.toml with sunpy we have had this style of dependancies to reduce duplication in our dep lists:
all = ["sunpy[asdf,dask,image,jpeg2000,map,net,timeseries,visualization]"]
tests = [
"sunpy[all,opencv,spice]",
https://github.com/sunpy/sunpy/blob/7d3cc09fed175db7f8e384433a4c7a27295b6797/pyproject.toml#L89-L91
This as it is at the moment fails because we haven't got a minimum version there, but we also don't want to put the name of the package in the generated requirement output at all.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the dependency declarations in pyproject.toml, especially the all and tests entries linked in the issue, then trace the plugin's dependency parsing and generated requirement output. Reproduce the failure with a package dependency that names the package itself, and consider the issue done when that package reference is accepted without appearing in generated requirements.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- build-system, tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100