OpenAstronomy / OpenAstronomy/github-actions-workflows
Better support for cibuildwheel config in `pyproject.toml`
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 21
- Forks
- 27
- Avg merge
- 2d 9h
- Merged PRs (30d)
- 1
Description
Currently the two publish workflows create jobs which set CIBW_BUILD and CIBW_ARCHS environment variables depending on the list of targets specified as an input to this workflow. These environment variables override any cibuildwheel config for build or archs set in pyproject.toml. (It should at least be documented that the publish workflows do not support build or archs within pyproject.toml.)
A fix would be to update tools/load_build_targets.py to parse pyproject.toml for build and archs configuration, and merge/adjust/replace the targets specified as an input to this workflow with the pyproject.toml config. I think the simplest solution would be to support either build config in pyproject.toml OR the targets workflow input.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading tools/load_build_targets.py and the two publish workflows to understand how targets become CIBW_BUILD and CIBW_ARCHS environment variables. Compare that behavior with the build and archs settings described in pyproject.toml; done means the workflows support either the pyproject.toml configuration or the targets input, or clearly document the limitation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- build-system, ci-cd
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100