OpenAstronomy / OpenAstronomy/github-actions-workflows

Why publish.yml flip between sh and bash?

Open
#152 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
21
Forks
27
Avg merge
2d 9h
Merged PRs (30d)
1

Description

https://github.com/OpenAstronomy/github-actions-workflows/blob/main/.github/workflows/publish.yml uses both shell: sh and shell: bash which is really confusing. I find that conditional does not work at https://github.com/OpenAstronomy/github-actions-workflows/issues/149#issuecomment-1685080175 and I am not sure how to fix it here.

Also see https://github.com/liberfa/pyerfa/pull/111

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with .github/workflows/publish.yml and compare the steps using shell: sh and shell: bash. Read the referenced comment on issue #149 and libERFA PR #111 for context on the conditional behavior. Done means the workflow's shell usage is consistent and the conditional behavior is verified.

Written by the indexing model from the issue text.

Assessment

Tech stack
bash, github-actions, shell
Domain
ci-cd
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.