OpenAssetIO / OpenAssetIO/OpenAssetIO-TraitGen
Move `creation_callback` arg to be final arg of `generate` function
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 7
- Forks
- 7
- PR merge metrics
- No merged PRs in 30d
Description
Spawned from this conversation.
Move the creation_callback argument in the generate method to the end of the function, so users can opt to omit it more often.
The reasoning is that it's rarely used, and it's a more complicated type than your bog standard ints and bools, so isn't very intuitive.
Default logging to std::err if non supplied.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in python/openassetio_traitgen/main.py at the generate function near line 179, where creation_callback is defined. Inspect how the function is called, then confirm the callback is the final argument and that omitted logging defaults to stderr; done means generation still works with the revised arguments.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- tooling
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100