OpenAssetIO / OpenAssetIO/OpenAssetIO-TraitGen

C++ test false positive errors with non-Linux hosts

Open
#123 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
7
Forks
7
PR merge metrics
No merged PRs in 30d

Description

What

C++ tests fail on non Linux hosts

Why

MacOS: the test "Deprecated specification causes deprecation compiler warning" fails, i.e. the CTest regex check of the build output cannot find the expected warning. Perhaps it's being optimised out?

Windows: unrecognised compiler flag -Wno-deprecated-declarations. We set this flag to prevent the main tests from failing (due to -Werror "warnings-as-error"). However, /wd4996 is the correct flag on Windows.

Unfortunately, enabling MacOS and Windows C++ tests is tricky, since we currently rely on a Docker build of OpenAssetIO for all C++ tests, and therefore only test Ubuntu. See https://github.com/OpenAssetIO/OpenAssetIO/issues/1235 (and its parent issue).

However, the integration tests in the upstream OpenAssetIO repo do run on multiple OSes, which is what flagged these issues.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the C++ test named “Deprecated specification causes deprecation compiler warning” and its CTest regex check, then compare the compiler-flag handling described for macOS and Windows. Done means the warning check works on macOS, the Windows suppression uses its recognized flag, and the integration tests pass on non-Linux hosts.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, docker
Domain
build-system, operating-systems, testing-qa
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.