OpenAPITools / OpenAPITools/openapi-generator

[BUG] Typescript-rxjs: api client instance created with withMiddleware() does not use new middlewares

Open
#9,098 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Issue: Bug
Dominant language
Java
Stars
26.8k
Forks
7.7k
PR merge metrics
PR metrics pending

Description

Bug Report Checklist
  • Have you provided a full/minimal spec to reproduce the issue?
  • Have you validated the input using an OpenAPI validator (example)?
  • Have you tested with the latest master to confirm the issue still exists?
  • Have you searched for related issues/PRs?
  • What's the actual output vs expected output?
  • [Optional] Sponsorship to speed up the bug fix or feature request (example)
Description

When creating new SomeApi instance like const newInstance = someApiInstance.withMiddleware(middlewares), the provided middlewares are not used by new instance.

This is because some methods, including rxjsRequest(), are defined as arrow functions and are copied to new instance in clone(). With current code, the methods in the new instance alway reads middleware of some old instance (this when creating the arrow functions).

IMO the current behavior effectively removed the meaning of withMiddleware().

openapi-generator version

generator-cli v4.3.1 (the problem still exists in master)

Related issues/PRs

They were changed to current form in https://github.com/OpenAPITools/openapi-generator/pull/3077/files , seemingly to save bytes.

Suggest a fix

Changing clone method to use new (like in typescript-fetch ) should fix it.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the TypeScript-RxJS runtime and its clone() implementation, then compare it with samples/client/petstore/typescript-fetch/builds/es6-target/src/runtime.ts. Reproduce the withMiddleware() case and verify that methods on the new client use the supplied middleware rather than the original instance's middleware.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
api, tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.