OpenAPITools / OpenAPITools/openapi-generator
[REQ] [cleanup] Automatic conversion of log parameters
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 26.8k
- Forks
- 7.7k
- PR merge metrics
- PR metrics pending
Description
@wing328 I noticed https://github.com/OpenAPITools/openapi-generator/pull/9090
In that pull request log parameters are used instead of string concatenation.
Instead of manual conversion I can provide an automatic transformation result.
I can provide https://github.com/cal101/cm-openapi-generator/tree/erefactor/master/x-judge/LogParametersRatherThanLogMessageCleanUp-1 etc.
What I don't like about them
- using function calls as parameters does not feel right
- they break formatting sometimes
But I wanted to make the offer for you to decide.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing pull request 9090 and the proposed transformation at cm-openapi-generator/tree/erefactor/master/x-judge/LogParametersRatherThanLogMessageCleanUp-1. Compare the automatic conversion with the existing log-parameter changes, paying attention to function-call parameters and formatting; done requires an agreed transformation approach.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- tooling
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100