OpenAPITools / OpenAPITools/openapi-generator

[BUG] DefaultCodegen.handleMethodResponse: importMappings vs. importMapping

Open
#8,803 2 comments 5 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Issue: Bug
Dominant language
Java
Stars
26.8k
Forks
7.7k
PR merge metrics
PR metrics pending

Description

Bug Report Checklist
  • Have you provided a full/minimal spec to reproduce the issue?
  • Have you validated the input using an OpenAPI validator (example)?
  • Have you tested with the latest master to confirm the issue still exists?
  • Have you searched for related issues/PRs?
  • What's the actual output vs expected output?
  • [Optional] Sponsorship to speed up the bug fix or feature request (example)
Description

DefaultCodegen.handleMethodResponse: importMappings parameter is never used: the class level importMapping is used instead...

https://github.com/OpenAPITools/openapi-generator/blob/eb3d6d2f1616bdba503c145d2349f798f85325f7/modules/openapi-generator/src/main/java/org/openapitools/codegen/DefaultCodegen.java#L3531-L3536

openapi-generator version

5.0.1

Suggest a fix
Schema responseSchema = unaliasSchema(ModelUtils.getSchemaFromResponse(methodResponse), importMappings);

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Open modules/openapi-generator/src/main/java/org/openapitools/codegen/DefaultCodegen.java around lines 3531-3536 and inspect how handleMethodResponse uses importMappings and importMapping. Done means the method uses the importMappings parameter, matching the suggested fix; the issue does not name a test to run.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
tooling
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.