OpenAPITools / OpenAPITools/openapi-generator
[BUG] DefaultCodegen.handleMethodResponse: importMappings vs. importMapping
Open
Nobody has claimed this yet.
Issue: Bug
- Dominant language
- Java
- Stars
- 26.8k
- Forks
- 7.7k
- PR merge metrics
- PR metrics pending
Description
Bug Report Checklist
- Have you provided a full/minimal spec to reproduce the issue?
- Have you validated the input using an OpenAPI validator (example)?
- Have you tested with the latest master to confirm the issue still exists?
- Have you searched for related issues/PRs?
- What's the actual output vs expected output?
- [Optional] Sponsorship to speed up the bug fix or feature request (example)
Description
DefaultCodegen.handleMethodResponse: importMappings parameter is never used: the class level importMapping is used instead...
openapi-generator version
5.0.1
Suggest a fix
Schema responseSchema = unaliasSchema(ModelUtils.getSchemaFromResponse(methodResponse), importMappings);
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open modules/openapi-generator/src/main/java/org/openapitools/codegen/DefaultCodegen.java around lines 3531-3536 and inspect how handleMethodResponse uses importMappings and importMapping. Done means the method uses the importMappings parameter, matching the suggested fix; the issue does not name a test to run.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100