OpenAPITools / OpenAPITools/openapi-generator

[BUG][KOTLIN-SPRING] Multipart file upload generate wrong type

Open
#8,333 14 comments 8 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Issue: Bug
Dominant language
Java
Stars
26.8k
Forks
7.7k
PR merge metrics
PR metrics pending

Description

Bug Report Checklist
  • Have you provided a full/minimal spec to reproduce the issue?
  • Have you validated the input using an OpenAPI validator (example)?
  • Have you tested with the latest master to confirm the issue still exists?
  • Have you searched for related issues/PRs?
  • What's the actual output vs expected output?
  • [Optional] Sponsorship to speed up the bug fix or feature request (example)
Description

The kotlin-spring generator generates multipart file upload attributes as org.springframework.core.io.Resource which actually cannot be handled by Spring Boot. org.springframework.web.multipart.MultipartFile should be generated instead: Uploading files guide

The spring generator handles this case correctly by applying some special case handling in the Mustache templates.

openapi-generator version

openapi-generator-maven-plugin:5.0.0

OpenAPI declaration file content or url

Multipart file upload sample spec

Steps to reproduce
  1. Generate server code using the kotlin-spring generator
  2. Generate server code using the spring generator
  3. Note that the spring generator generates the file paramter as List<MultipartFile> while the kotlin-spring generator generates List<Resource>
Related issues/PRs
Suggest a fix

Apply the same special case handling in the templates like the spring generator

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the kotlin-spring Mustache templates and compare their multipart handling with the spring generator's special-case templates. Generate server code from the linked multipart sample spec using the openapi-generator Maven plugin, then verify that the file parameter is generated as List rather than List.

Written by the indexing model from the issue text.

Assessment

Tech stack
kotlin, openapi, spring
Domain
api, backend, tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.