OpenAPITools / OpenAPITools/openapi-generator
[Enhancement] Remove OpenAPI parameter from DefaultCodegen methods
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 26.8k
- Forks
- 7.7k
- PR merge metrics
- PR metrics pending
Description
The methods hasBodyParameter, hasFormParameter, getConsumesInfo, getProducesInfo, addOneOfInterfaceModel, getOneOfAnyOfDescendants and discriminatorFound doesn't need to have an OpenAPI object as a parameter since the DefaultCodegen class already has it as an instance attribute and its its always required.
Also, removing the static property from getConsumesInfo and getProducesInfo facilitates override them.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the DefaultCodegen class and locating hasBodyParameter, hasFormParameter, getConsumesInfo, getProducesInfo, addOneOfInterfaceModel, getOneOfAnyOfDescendants, and discriminatorFound. Then trace their callers and overrides to identify all OpenAPI arguments and static declarations that must change. Done means the methods use the existing instance attribute and overrides remain possible without the static restriction.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, openapi
- Domain
- api, tooling
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100