OpenAPITools / OpenAPITools/openapi-generator
[REQ][JAVA][webclient] query parameters are not encoded
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 26.8k
- Forks
- 7.7k
- PR merge metrics
- PR metrics pending
Description
This PR removed the query parameter double encoding.
Issue link
But instead of removing only one iteration of encoding from the double encoding, it removed both, so instead of double encoded parameters now they are not encoded at all.
The problem is with this line. UriComponentsBuilder.build() method does not encode properly. See this SO issue.
Proposal:
-
change it back to builder.encode().toUriString()
-
or make it configurable to encode the parameters.
I can create a PR if we agree on which is the preferred way.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect the Java webclient query-parameter construction at the line changed by PR #5255 and its referenced commit, focusing on UriComponentsBuilder.build(). Compare the proposed encoding behavior with the issue’s expected result; done means parameters are encoded once rather than left unencoded or encoded twice.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, spring
- Domain
- api
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100