OpenAPITools / OpenAPITools/openapi-generator

[BUG][nodejs-express-server] WHATWG urlencoding

Open
#7,944 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Issue: Bug Server: Nodejs
Dominant language
Java
Stars
26.8k
Forks
7.7k
PR merge metrics
PR metrics pending

Description

I am using got to make requested to my server, and when passing the query parameter $.phoneNumber[*], the server rejects the request.

got follows WHATWG and encodes the parameter as %24.phoneNumber%5B*%5D. (notice the * character)

If I manually encode it to %24.phoneNumber%5B%2A%5D instead, it works.

Not sure who's in the "right" here, but this incompatibility is problematic ...

See https://github.com/sindresorhus/got/issues/1524

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the nodejs-express-server request using the two encoded forms shown in the report, then compare its behavior with got's WHATWG encoding and the linked got issue. Done should define and verify compatible handling for the phoneNumber query parameter, but the report does not identify a file or test.

Written by the indexing model from the issue text.

Assessment

Tech stack
express, node.js
Domain
api, backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.