OpenAPITools / OpenAPITools/openapi-generator

[REQ] [csharp] Remove optional arguments from Model Constructors when optionalMethodArgument = false

Open
#6,029 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Enhancement: Feature
Dominant language
Java
Stars
26.8k
Forks
7.7k
PR merge metrics
PR metrics pending

Description

Is your feature request related to a problem? Please describe.

The optionalMethodArgument flag for csharp currently will remove optional arguments from constructors in the API. It does not remove optional constructor arguments from elsewhere in the code, including data models.

Describe the solution you'd like

Expand optionalMethodArgument flag to also remove the optional arguments from the constructors in the models.

Describe alternatives you've considered

Another configuration flag could also be added for this, but the existing one probably makes the most sense.

Additional context

AutoMapper is not (yet) compatible with optional constructor arguments. See https://github.com/AutoMapper/AutoMapper/issues/3392.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names no files or tests. Start by locating the C# generator's handling of optionalMethodArgument and the model-constructor generation path; verify that generated models omit optional constructor arguments when the flag is false, while existing API behavior remains covered.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
tooling
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.