OpenAPITools / OpenAPITools/openapi-generator

[REQ] Move phpLegacySupport option from PhpSymfonyServerCodegen.java to AbstractPhpCodegen.java

Open
#5,480 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Enhancement: Feature
Dominant language
Java
Stars
26.8k
Forks
7.7k
PR merge metrics
PR metrics pending

Description

Is your feature request related to a problem? Please describe.

the phpLegacySupport flag is available to the php-symfony generator, and it produces more strongly typed code. It is not available, however, in the main php generator.

Describe the solution you'd like

I think this option should be moved up to the parent AbstractPhpCodegen class so that all child php generators can use this option. Here is the logic in question.

Describe alternatives you've considered

Additional context

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the phpLegacySupport logic in modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/PhpSymfonyServerCodegen.java, around lines 361-380, and compare it with AbstractPhpCodegen.java. Move the option to the parent so it is available to the main php generator and other child PHP generators, then verify the affected generators still behave correctly.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, php
Domain
api, tooling
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.