OpenAPITools / OpenAPITools/openapi-generator

[REQ] Remove `RC` wrapping for Rust client

Open
#5,296 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Enhancement: Feature
Dominant language
Java
Stars
26.8k
Forks
7.7k
PR merge metrics
PR metrics pending

Description

Is your feature request related to a problem? Please describe.

The RC wrapping Configuration generated in clients makes it impossible to share the client between threads (implements !Send), not even if you wrap it with Arc + Mutex.

For underlying clients like reqwest, this is a shame because that client can be shared between threads.

Describe the solution you'd like

For the most part, once someone has created an API Client using the Configuration, we can probably assume they're not going to use it again. We can then simply consume it.

We can then simply just hold the configuration (and its client) instead of this:

https://github.com/OpenAPITools/openapi-generator/blob/f2c1bdbf6feed76ac24215f931981990c2dfdc1e/modules/openapi-generator/src/main/resources/rust/reqwest/client.mustache#L29

Describe alternatives you've considered

We can also wrap with Arc instead.

Additional context

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with modules/openapi-generator/src/main/resources/rust/reqwest/client.mustache at the Configuration wrapping referenced in the issue, then trace how generated Rust reqwest clients receive and retain that configuration. Done means the generated client no longer uses the RC wrapping and can be shared between threads while retaining the underlying client and configuration.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.