OpenAPITools / OpenAPITools/openapi-generator

[BUG][Java][Spring] Always generate the default constructor if it is the only constructor

Open Beginner friendly
#24,747 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Issue: Bug
Dominant language
Java
Stars
26.8k
Forks
7.7k
PR merge metrics
PR metrics pending

Description

Bug Report Checklist
  • Have you provided a full/minimal spec to reproduce the issue?
  • Have you validated the input using an OpenAPI validator?
  • Have you tested with the latest master to confirm the issue still exists?
  • Have you searched for related issues/PRs?
  • What's the actual output vs expected output?
  • [Optional] Sponsorship to speed up the bug fix or feature request (example)
Description

The generator does not generate the default constructor if it is the only constructor. This is problematic, e.g., when such a class is in a package that is exported by a Java module and the module is compiled with javac -Xlint:all -Werror, because it fails the lint check missing-explicit-ctor.

openapi-generator version

v7.24.0

OpenAPI declaration file content or url

openapi.yaml

Generation Details

config.json

Steps to reproduce
  • in a directory X, create openapi.yaml and config.json with the contents as above
  • from within X, run docker run --rm -v .:/local openapitools/openapi-generator-cli:v7.24.0 generate --strict-spec true --input-spec /local/openapi.yaml --generator-name spring --config /local/config.json --output /local/output
  • open .\output\src\main\java\org\openapitools\model\Foo.java

actual: the default constructor is not generated

expected: the default constructor is generated

Related issues/PRs
Suggest a fix

I assume this will require an update to the pojo.mustache template.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the spring generator command in the issue using openapi.yaml and config.json, then inspect the generated Foo.java and the pojo.mustache template mentioned in the report. Done means the generated class includes its default constructor when it is the only constructor, while the existing reproduction still succeeds.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, spring
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Active
Clarity
Clearly specified
Newbie friendliness
82/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.