OpenAPITools / OpenAPITools/openapi-generator

[JAX-RS] Generator can't add x-field-extra-annotation with comma

Open
#22,807 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Issue: Bug
Dominant language
Java
Stars
26.8k
Forks
7.7k
PR merge metrics
PR metrics pending

Description

Bug Report Checklist
  • Have you provided a full/minimal spec to reproduce the issue?
  • Have you validated the input using an OpenAPI validator?
  • Have you tested with the latest master to confirm the issue still exists?
  • Have you searched for related issues/PRs?
  • What's the actual output vs expected output?
  • [Optional] Sponsorship to speed up the bug fix or feature request (example)
Description

I wanted to generate Code with Jaxr-Rs Generator with additional Properties for JsonFormat and the generated Class only inludes the definition only until comma sign

openapi-generator version

7.19.0

OpenAPI declaration file content or url

Additional propeties from yaml:

apiNamePrefix=I
                           <additionalProperty>
                                vendorExtensions.x-field-extra-annotation=@com.fasterxml.jackson.annotation.JsonFormat(shape
                                = com.fasterxml.jackson.annotation.JsonFormat.Shape.STRING, pattern = "yyyy-MM-dd'T'HH:mm:ss-SSS")</additionalProperty>
                        </additionalProperties>
Generation Details

Generated Class get following content:

public class TOSVAktuellResponse implements Serializable {
@com.fasterxml.jackson.annotation.JsonFormat(shape
= com.fasterxml.jackson.annotation.JsonFormat.Shape.STRING
private List listeSvIdentifier = new ArrayList<>();
@com.fasterxml.jackson.annotation.JsonFormat(shape
= com.fasterxml.jackson.annotation.JsonFormat.Shape.STRING
private LocalDateTime letzterAblageZeitpunkt = null;

Steps to reproduce
  1. Define yaml
  2. Build wit maven an Jaxs-rs Generator
Related issues/PRs
Suggest a fix

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the JAX-RS generator's handling of the vendorExtensions.x-field-extra-annotation additional property and reproduce the report through the Maven generation steps. Compare the generated class with the configured JsonFormat annotation; done means the complete annotation, including text after commas, is retained in generated fields.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
devtools
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.